Home / Technology / Firefox 64 built with GCC and Clang

Firefox 64 built with GCC and Clang

One of my tasks (as GCC maintainer of the inter-procedural optimization framework) is to make sure that it works well with real world programs as opposed to smaller scale benchmarks like SPEC. I am slowly getting ready for my annual attempt to verify that GCC 9 is doing well optimizing large applications, but because recent switch of
official and
Fedora builds from GCC to Clang (
Fesco ticket), I decided to take a quick look on how GCC 8 built binaries compares to the official release builds for Linux.

Clang built Firefox is claimed to outperform GCC, but it is hard to get actual numbers. Firefox builds switched from GCC 6 builds (GCC 6 was released in 2016) with profile guided optimization (PGO) to Clang 7 builds (latest release) which in addition enable link time optimization (LTO). Link-time optimization can have important performance and code size impact.

Martin Stránský (RedHat maintainer of the Firefox package) compared GCC 8 built binary with Clang 7, and his setup was not completely comparable either because of the stack protector settings and other security centric system-wide defaults of Fedora. Moreover GCC -O2 defaults are (in my opinion unfortunately) still not enabling vectorization and unrolling which may have noticeable effects on benchmarks. This is a historical decision bit motivated by pressure Clang gave on us with compile times. This has changed. I am in process of evaluating what can be done with this default.

For my testing. I built LTO and PGO enabled Firefox using GCC 8 (sadly no official release since I had to fix one bug) and Clang 7 and compared them to two official Firefox binaries:

  1. last release built with GCC: Firefox 63, and 
  2. first release build with Clang: Firefox 64.

Any comments and corrections to my methods are welcome.

Summary

To summarize my findings, I found that watchdog in Firefox kills the training run before it had time to stream profile data to disk. This bug in Firefox build system has bad effect on performance, because compiler has only partial profile data. Fixing this issue leads to faster binaries. GCC is a lot more careful about binary size (Clang builds have
48% bigger code section!) but for tasks which are covered by train run GCC 8 LTO+PGO binary performs well (and win in benchmarks I tried). It is probably possible to find benchmarks that test things not covered by train run where GCC code will likely perform slower than Clang because it is a lot smaller. However benchmarks I found discussed in the Fedora ticket above all like GCC. Clang currently builds about 10% faster, I hope to reverse the sides with GCC 9 🙂

Comparing compiler performance on such a complex project as Firefox is delicate job. I plan to get Firefox’s benchmark infrastructure (Talos) running again and do more detailed analysis which also compare GCC 9.

You can compare this with my earlier tests of Firefox

Try it

I have uploaded a
binary build with GCC 8, with link-time optimization and profile feedback. If your curiosity exceeds the fear of running random binaries from the net, you are welcome to try it out. It is built from Firefox 64 release. You can compare it to the official build and build provided by your favourite distro. (Is there an stable link to the Firefox 64 official Linux binary?)

I am just typing my post using it and it seems to work on both Debian and Tumbleweed distros.

Profile data collection problem

PGO in Firefox build system is automated. If enabled in
mozconfig, the build first produces a binary with profile instrumentation, then starts a local webserver and trains the application on few things (there is Speedometer, SunSpider and few other things I did not immediately recognize) and proceeds by building the final binary next.

One problem is that if train run fails, the build system will not inform you. For example, if you do not have X server available, your binary will be effective on printing error message but nothing else.  Sometimes the train run crashes and then the code quality goes completely off. I learnt the habit of using Xvnc and observing the train run remotely to check that it does what it should. I am surprised that Firefox developers did not added a check that each of the tasks has finished successfully. It would be useful as a regression suite, too.

Issue I run into this time is bit subtle. It is not visible during testing but it can be seen as following message in the build log:

MOZ_CRASH(Shutdown too long, probably frozen, causing a crash.) at /aux/hubicka/firefox-2018/release/toolkit/components/terminator/nsTerminator.cpp:219

This message (hidden between 57958 others) basically means that the worker threads was killed during exit and thus the profile data collected from the actual training benchmark was never saved to disk (and thus invisible to the compiler). It turns out that this is a timeout in Firefox internal watchdog that kills individual subprocesses if they seems to have hanged up during exit. GCC profiling runtime streams all data from the global destructor in
libgcov library and for Firefox it may take some time. GCC profile data is organized into multiple files (one for every object file) while Clang’s is one big file which is later handled by specialized tool. I suppose one large file may be faster to write than 8k smaller files.

I use this patch to increase the timeout for training runs.

GCC LTO bug

Fixing the PGO collection problem finally got me optimized binary, this time it however did not start. Problem is caused by a long standing bug in GCC command line option handling where command line options was incorrectly merged for the function wrapping global constructor. This led to enabling AVX and since the global constructor now gets some code auto-vectorized the binary crashed on invalid instruction during the build (my testing machine has no AVX).

I have now fixed this for GCC 8 and mainline and plan to backport it to GCC 7. So to reproduce my builds, you either new recent GCC 8 snapshot or you can work-around by disabling the cdtor merging pass by using -fdisable-ipa-cdtor.

This optimization combines static constructors and destructors from individual translation units into single function. It was in fact also motivated by Firefox which used to have many constructors (remember, each time you include iostreams you implicitly get one) and running them caused important lag during startup accessing many parts of the code segments. It seems that this problem was fixed by hand over the time and thus this optimization is not very important for Firefox anymore.

This bug affect link-time optimized builds only where correct behaviour with respect to the optimization options passed at compile-time is quite challenging. This bug needs several factors to trigger – one needs to have at least one file build with AVX codegen enabled, object files needs to be passed in right order, there needs to be global constructor which is autovectorizable and one needs to execute final binary on CPU without AVX support. I suspect that this also may be origin of the problem with Firefox crashing at startup seen by RedHat guys recently.

LTO module is intrusive change to the whole toolchain and unfortunately because the LTO adoption is still pretty low surprises happens. At SUSE we now work actively on enabling link-time by default after switching to GCC 9. Hopefully this will hammer out similar issues. At the moment only about 500 out of 11k packages fails to build with link-time optimization some for a good reasons. We will concentrate on fixing the issues prior GCC 9 release.

File size

While I did not manage to 100% match the Firefox official builds, it seems that my Clang 7 build is close enough to make comparision meaningful.

48% code segment size increase for switching compilers is little bit surprising. I think there are two factors affecting this.

  1. GCC is more aggressive to optimize for size regions that was not trained. 
  2. The traditional LTO where whole program is loaded back to compiler which runs it through the back-end as if it was all one compilation unit is too slow in practice. Both GCC and Clang use to more scaleable model (you can get traditional LTO with -flto-partition=none for GCC and -flto=full for Clang).

    The faster LTO modes necessarily trades some code quality for performance. This is where both compilers differs. GCC’s LTO was designed to run whole inter-procedural optimization queue using summaries and later dispatch local optimization into multiple worker processes, while Clang’s thin LTO is built around assumption that GCC’s approach will not scale enough and works differently. Thin linker does just part of inter-procedural optimization decisions and rest of translation is per-file based..

    Time will tell which of the approaches will scale better. I find it interesting challenge to get GCC build times on par or better than Clangs even for project of size of Firefox. It would be always possible to combine both approaches if linking bigger applications than Firefox becomes important. So far I do not have a testcase to play with.

Other interesting observation is that my LTO build is about the same size as official build of Firefox 63. Usually LTO builds are noticeably smaller. It may be because official build was suffering from the same loss of profile data as observed on my builds. I plan to build GCC 6 binary and look into it later.

Understanding performance of builds with PGO enabled

The train run of Firefox covers about 15% of the whole binary. Bear in mind that benchmarking code that was not at all trained during the build will make you to measure performance of code optimized for size (and it won’t be very good). This can be handled by improving the train run coverage in Firefox or disabling PGO for those modules where it can not be done (such as hardware specific video decoders).

This makes direct GCC to Clang comparison bit harder, because Clang seems to not optimize for size cold regions or do that a lot less aggressively.

I believe GCC’s default is correct one because size of binaries matters in practice, but it may not be best one in all scenarios. If it would seem useful, I can provide command line option for GCC that will disable aggressive code size optimizations for cold parts of the program.

GCC and Clang also differs in a way they interpret -Os. For GCC it means “do everything possible to get smaller binary”, while for Clang it seems to be more “disable some of the most code size expensive optimizations”. Clang provides -Oz that is closer to what GCC’s -Os have. For a while I was thinking that having such less aggressive size optimization in GCC would be also useful especially in scenarios where GCC auto-guesses cold regions and there is chance that it was wrong. This is not hard to implement and may be something to do next year.

Benchmarks

I started with SunSpider and Speedometer benchmarks which I have noticed are part of the default train run. This makes most apple-to-apple comparison of abilities of code generators without being affected by choice of code quality for cold regions of the binary. Of course in practice binaries are never perfectly trained and thus I also include other benchmarks if you scroll down.


Sometimes more is better and sometimes it is the opposite. I always ordered data from best run to worst for easy orientation.

Sunspider is now somewhat historical javascript benchmark that seems to be superseeded by JetStream.

Speedometer is closer to the noise factor, but shows difference at least between GCC 8 binary and Firefox 63. It measures responsibility of the browser.

Dromaeo DOM is the first benchmark which is not part of the train run. It tests DOM and CSS queries. I show results of run using http://dromaeo.com/?dom|jslib|cssquery. This is subset of the full suite that is not very centric to the javascript JIT performance and I have earlier observed it is more sensitive to compiler generated code. I have run the default set of benchmarks earlier also observing a difference which was about 1.5% (comparing GCC 8 build with Firefox 64 official binary). They runs for a while, I will find time to re-run them later. From perf profiles I know that the JavaScript benchmark tests a lot of JIT generated code, some of JIT performance itself and simple C routines, such as UTF conversions.

You can check detailed comparison of individual runs. (order is the same as I run it: GCC 8, Firefox 63, Clang 7, Firefox 64). I am bit surprised by difference between Clang and Firefox 64 release.

MotionMark is fun to watch benchmark testing rendering speed. Eventually I got bored however and produced fan-art.

Hope they will stay friends 🙂

Results are very close to noise factor and may be affected by fact that I run the tests in Xvnc. It is bit strange that my Clang build differs from official one. I will try to find time (and suitable machine) to run this test locally and see if the results are more trustworthy. Similar issues are seen with BaseMark that I eventually gave up on.

JetStream is testing performance of most advanced web applications. Seems you are better to build with old GCC in this case!

ARES-6 tests ECMAScript 6 applications. I do not know what it is, but I am sure it is important.

Runtime memory use

This I measured by letting the Firefox to start, observing resources in top and waiting for few seconds for number to settle down. I was hoping for more interesting numbers here because GCC with LTO has a code section reordering algorithms which was developed by Martin Liška and was
motivated by Firefox. This is done by measuring the average time of first execution of every function and then ordering code segment in a way that during the startup just tiny portion of it is touched and execution is done in the increasing order.

It does not show much and the resource usage seems to be fully justified by the code segment size. At some point Firefox started to mmap whole binary to prevent page demand loading from seeking too much. This seems to be still the case today. I wonder how that works on SSD disks?

Build time and built-time memory usage

This is memory and CPU use graph I collected from builds.

Memory and CPU use during GCC 8 build
Memory and CPU use duuring LLVM build

Clang build time is about 9% better (91 minutes compared to 100). I will give GCC 9 a try because I spent good part of this year speeding LTO up. One aspect where Clang wins hands down is memory use during build. This is partly caused by the technical differences between LTO implementations discussed earlier. One other aspect it GCC’s use of garbage collector. Fortunately the peak of memory use is during the link-time when parallel builds are performed. This issue is solved in GCC9 which should fit here under 10GB. I will write on that later.

Note that reducing parallelism from 16 down will get you smaller peak memory use so Firefox should build with GCC on boxes with 10GB.

Update: According to reddit post my Clang build procedure could be improved, because the default training run is very small. Instructions are here and here. I will give it a try.

Details of my setup

For my tests I use AMD Bulldozer based machine (AMD Opteron 6272) with 8 cores and 16 threads running Debian 9.6.

I built GCC 8 from current SVN trunk configured with

../configure --with-build-config=bootstrap-lto --disable-multilib  
--disable-werror --disable-plugin

and build with

make profiledbootstrap

 I also tested GCC trunk (which is in early stage3 heading to GCC 9 release) with same configuration.

Since LLVM webpage no longer has official binaries for debian I downloaded llvm 7 release and built it myself following the bootstrap and LTO+PGO procedure. For that one needs to first build LLVM+clang+lld+runtime with GCC, then build version collecting profile data and finally build LTO optimized binary with profile feedback. To gather profile data I used

/usr/bin/cmake  -C ../llvm-7.0.0.src/tools/clang/cmake/caches/PGO.cmake 
../llvm-7.0.0.src  -DCMAKE_BUILD_TYPE=Release 
-DCMAKE_INSTALL_PREFIX=/aux/hubicka/llvm7-install-fdo -DLLVM_TARGETS_
TO_BUILD=X86 -DLLVM_BINUTILS_INCDIR=/aux/hubicka/binutils-install/include/  -G Ninja

And to obtain final build I use:

/usr/bin/cmake  -DCMAKE_C_COMPILER=/aux/hubicka/llvm7-install-fdo/bin/clang 
-DCMAKE_CXX_COMPILER=/aux/hubicka/llvm7-install-fdo/bin/clang++ 
-DLLVM_PROFDATA_FILE=/aux/hubicka/./build2/tool
s/clang/stage2-instrumented-bins/tools/clang/utils/perf-training/clang.profdata 
../llvm-7.0.0.src  -DCMAKE_BUILD_TYPE=Release 
-DCMAKE_INSTALL_PREFIX=/aux/hubicka/llvm7-install-fdo -DLLVM_
TARGETS_TO_BUILD=X86 -DLLVM_BINUTILS_INCDIR=/aux/hubicka/binutils-install/include/  
-G Ninja  -DLLVM_ENABLE_LTO=Thin -DCMAKE_RANLIB=/aux/hubicka/llvm7-install-fdo/bin/llvm-ranlib  
-DCMAKE_AR=/aux/hubicka/llvm7-install-fdo/bin/llvm-ar 

It is first time I attempted to build PGO optimized clang so I hope I did that correctly.

Update: According to reddit post my Clang build procedure could be improved, because the default training run is very small. Instructions are here and here. I will give it a try.

Finally I use pretty basic mozconfig:

mk_add_options MOZ_MAKE_FLAGS="-j16"
CC=/aux/hubicka/trunk-install/bin/gcc
CXX=/aux/hubicka/trunk-install/bin/g++
export PATH=/aux/hubicka/trunk-install/bin/:$PATH
MYFLAGS="-O3"
mk_add_options OS_CFLAGS="$MYFLAGS"
mk_add_options OS_CXXFLAGS="$MYFLAGS"
mk_add_options OS_LDFLAGS="$MYFLAGS"
ac_add_options --enable-optimize=-O3
  
ac_add_options --enable-application=browser
ac_add_options --enable-debug-symbols
  
ac_add_options --disable-valgrind
ac_add_options --enable-lto
ac_add_options --enable-tests
ac_add_options MOZ_PGO=1
  
export moz_telemetry_reporting=1
export mozilla_official=1
  
ac_add_options --enable-linker=gold
  
export CFLAGS="$MYFLAGS"
export CXXFLAGS="$MYFLAGS -fpermissive"
export LDFLAGS="$MYFLAGS"
mk_add_options MOZ_OBJDIR=<mydir>

I thus use gold for both GCC and Clang build. For clang I additionally need

ulimit -n 10240

because it runs out of file descriptors during linking. This does not happen with lld, but then
elfhack fails.

I have set power saving to performance for my testing.

About

Leave a Reply

Your email address will not be published. Required fields are marked *

*

x

Check Also

Work on Boeing crash plane ‘not adequately funded’

---Source